Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue publishing new release on v1.9.0 #3115

Closed
3 tasks done
G-Rath opened this issue May 19, 2022 · 8 comments
Closed
3 tasks done

Issue publishing new release on v1.9.0 #3115

G-Rath opened this issue May 19, 2022 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@G-Rath
Copy link

G-Rath commented May 19, 2022

What happened?

I went to publish a new version (v0.5.0) of osv-detector and it failed right at the end when trying to push the release to github:

   ⨯ release failed after 170.51s error=scm releases: failed to publish artifacts: PATCH https://api.github.com/repos/G-Rath/osv-detector/releases/0: 404 Not Found []
Error: The process '/opt/hostedtoolcache/goreleaser-action/1.9.0/x64/goreleaser' failed with exit code 1

I tried restarting the build, and with a new tag (v0.5.1) just in case it was being thrown off by the release & tag previously being drafted and then deleted (which I think I did for v0.5.0, but can't remember so I tried a new tag just incase).

I've not changed anything in my GitHub profile or repository - the only difference I knew of between these runs and the last release (which was a month ago) was that that run was using v1.8.3, and these runs were using v1.9.0.

So I pinned goreleaser to v1.8.3 (G-Rath/osv-detector#97) and that was successful: https://github.com/G-Rath/osv-detector/runs/6513592978?check_suite_focus=true

How can we reproduce this?

I don't know for sure - hopefully it will be enough to use my actions workflow:

  goreleaser:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - run: git fetch --prune --unshallow
      - uses: actions/setup-go@v3
        with:
          go-version: ${{ env.GO_VERSION }}

      - uses: actions/cache@v3
        with:
          path: |
            ~/.cache/go-build
            ~/go/pkg/mod
          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
          restore-keys: |
            ${{ runner.os }}-go-
      - name: Run GoReleaser
        uses: goreleaser/goreleaser-action@v2
        with:
          version: 1.9.0
          args: release --rm-dist
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

goreleaser version

v1.9.0

GoReleaser Check

  • goreleaser check shows no errors

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

Looking over the changelogs, the main change that jumped out at me was that go-github was updated from v43 to v44.

@G-Rath G-Rath added bug Something isn't working triage Issue pending triage by one of the maintainers labels May 19, 2022
@cube2222
Copy link

Hey!
Same: https://github.com/cube2222/octosql/runs/6515675077
I now pinned to v1.8.3 and it started working again.

@ybelMekk
Copy link

@caarlos0
Copy link
Member

everyone using draft releases, right?

probably #3073

@caarlos0
Copy link
Member

One thing I just realized about this is that it won't actually work as the artifacts from the previous release will still be there and have the same name...

this will likely require more work, so I'll revert both the fix and original change, at least for now.

@caarlos0 caarlos0 removed the triage Issue pending triage by one of the maintainers label May 20, 2022
@szh
Copy link

szh commented May 20, 2022

Will there be a patch release with this included in the next day or two?

@caarlos0
Copy link
Member

Will there be a patch release with this included in the next day or two?

yes, today probably

@caarlos0
Copy link
Member

released!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants