Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update existing release drafts #3073

Merged
merged 1 commit into from May 9, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
46 changes: 40 additions & 6 deletions internal/client/github.go
Expand Up @@ -200,6 +200,36 @@ func (c *githubClient) CreateFile(
return err
}

// you can't get a an existing draft by tag
// so we must find one in the list of all releases
func (c *githubClient) findDraftRelease(ctx *context.Context) (*github.RepositoryRelease, error) {
opts := &github.ListOptions{
Page: 1,
PerPage: 100,
}
for {
releases, resp, err := c.client.Repositories.ListReleases(
ctx,
ctx.Config.Release.GitHub.Owner,
ctx.Config.Release.GitHub.Name,
opts,
)
if err != nil {
return nil, err
}
for _, r := range releases {
if r.TagName == &ctx.Git.CurrentTag {
return r, nil
}
}
if resp.NextPage == 0 {
break
}
opts.Page = resp.NextPage
}
return nil, nil
}

func (c *githubClient) CreateRelease(ctx *context.Context, body string) (string, error) {
var release *github.RepositoryRelease
title, err := tmpl.New(ctx).Apply(ctx.Config.Release.NameTemplate)
Expand All @@ -221,12 +251,16 @@ func (c *githubClient) CreateRelease(ctx *context.Context, body string) (string,
data.DiscussionCategoryName = github.String(ctx.Config.Release.DiscussionCategoryName)
}

release, _, err = c.client.Repositories.GetReleaseByTag(
ctx,
ctx.Config.Release.GitHub.Owner,
ctx.Config.Release.GitHub.Name,
ctx.Git.CurrentTag,
)
if ctx.Config.Release.Draft {
release, err = c.findDraftRelease(ctx)
} else {
release, _, err = c.client.Repositories.GetReleaseByTag(
ctx,
ctx.Config.Release.GitHub.Owner,
ctx.Config.Release.GitHub.Name,
ctx.Git.CurrentTag,
)
}
if err != nil {
release, _, err = c.client.Repositories.CreateRelease(
ctx,
Expand Down