Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SignedUrls on every chunk in gcs #417

Merged
merged 14 commits into from Jan 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4,399 changes: 0 additions & 4,399 deletions api/open_saves.pb.go

This file was deleted.

19 changes: 19 additions & 0 deletions api/open_saves.proto
Expand Up @@ -63,6 +63,9 @@ service OpenSaves {
rpc CreateChunkedBlob(CreateChunkedBlobRequest)
returns (CreateChunkedBlobResponse) {}

// CreateChunkUrls returns the TTL signed url for the record blob chunks.
rpc CreateChunkUrls(CreateChunkUrlsRequest) returns (CreateChunkUrlsResponse) {}

// UploadChunk uploads and stores each each chunk.
rpc UploadChunk(stream UploadChunkRequest) returns (ChunkMetadata) {}

Expand Down Expand Up @@ -553,6 +556,22 @@ message CreateChunkedBlobResponse {
string session_id = 1;
}

message CreateChunkUrlsRequest {
// The key of the store that the record belongs to.
string store_key = 1;

// The key of the record to get.
string key = 2;

// TTL
int64 ttl_in_seconds = 3;
}

message CreateChunkUrlsResponse {
// Public signed URLs of the chunk objects uploaded against the record ordered according to chunk number
repeated string chunk_urls = 1;
}

// UploadChunkRequest is used by UploadChunk, which is a client-streaming
// method. The first message should contain the metadata, and the subsequent
// messages should contain the content field until EOF.
Expand Down