feat: add SignedUrls on every chunk in gcs #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongalex
reviewed
Jan 20, 2023
|
/gcbrun |
|
/gcbrun |
|
This implementation was tested outside of Cloud Build, where we have been having issues with running the tests. We have simply added a t.Skip() to move this forward until someone at Google can find out more about what's wrong when we use GCB to run this specific test. |
loranger2k
added a commit
that referenced
this pull request
Jan 23, 2023
This reverts commit a4f6e4d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / Why we need it:
This PR add the ability for the server to get signed URLs for the chunks inside the GCS bucket.
Which issue(s) this PR fixes:
Closes #414
Special notes for your reviewer: