Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove pumpify dep #1815

Closed
wants to merge 29 commits into from
Closed

chore: remove pumpify dep #1815

wants to merge 29 commits into from

Conversation

shaffeeullah
Copy link
Contributor

Steps toward #1743

@shaffeeullah shaffeeullah requested review from a team as code owners March 14, 2022 20:36
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Mar 14, 2022
@shaffeeullah shaffeeullah changed the title Removepumpify chore: remove pumpify dep Mar 14, 2022
@shaffeeullah shaffeeullah added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 14, 2022
shaffeeullah and others added 18 commits March 21, 2022 17:06
@shaffeeullah
refactor pumpify
be2cbc8
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
bab68db 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@shaffeeullah
refactored code
7ee77f9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
4c44560 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@shaffeeullah
added dummy callbacks
1795399
@shaffeeullah
added dummy callbacks
2fef8f5
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
3a392fb 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@shaffeeullah
more refacroting
3a9f751
@shaffeeullah
Merge branch 'removepumpify' of github.com:googleapis/nodejs-storage …
13b39ff 
…into removepumpify
@shaffeeullah
refactored code
b70c2c8
@shaffeeullah
refactored code
080f230
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
1fc39a8 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@shaffeeullah
more refactoring
da0a226
@shaffeeullah
added new stream to pipeline
f483ef5
@shaffeeullah
Merge branch 'removepumpify' of github.com:googleapis/nodejs-storage …
7a98a23 
…into removepumpify
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
e1bc8d7 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@danielbankhead
Merge branch 'main' of https://github.com/googleapis/nodejs-storage i…
5c165db 
…nto removepumpify
@danielbankhead
feat: Remove pumpify WIP
227855f
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Apr 6, 2022
@danielbankhead
Copy link
Member

Closing in favor of:

@danielbankhead danielbankhead deleted the removepumpify branch May 6, 2022 00:24
@danielbankhead danielbankhead mentioned this pull request May 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shaffeeullah @danielbankhead