Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(deps): Remove pumpify dependency #1915

Closed
danielbankhead opened this issue May 6, 2022 · 2 comments · Fixed by #2029
Closed

refactor(deps): Remove pumpify dependency #1915

danielbankhead opened this issue May 6, 2022 · 2 comments · Fixed by #2029
Assignees
@danielbankhead
Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@danielbankhead
Copy link
Member

Native streams should suffice.
@danielbankhead danielbankhead added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. labels May 6, 2022
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label May 6, 2022
This was referenced May 6, 2022
Closed
Closed
@danielbankhead
Copy link
Member Author

#1815 has some good tips in terms of direction/implementation

@shaffeeullah shaffeeullah mentioned this issue May 23, 2022
Closed
@danielbankhead danielbankhead self-assigned this Aug 5, 2022
@danielbankhead
Copy link
Member Author

danielbankhead commented Aug 9, 2022 •
edited

Will start after #2022 in order to avoid merge/implementation conflicts

@danielbankhead danielbankhead mentioned this issue Aug 11, 2022
Merged
@danielbankhead danielbankhead mentioned this issue Aug 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielbankhead danielbankhead

Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove pumpify googleapis/nodejs-storage
1 participant
@danielbankhead