Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up for gcs-resumable-upload #1743

Closed
6 tasks done
danielbankhead opened this issue Jan 7, 2022 · 3 comments · Fixed by #1914
Closed
6 tasks done

Clean-up for gcs-resumable-upload #1743

danielbankhead opened this issue Jan 7, 2022 · 3 comments · Fixed by #1914
Assignees
@danielbankhead
Labels
api: storage Issues related to the googleapis/nodejs-storage API. type: cleanup An internal cleanup or hygiene concern.

Comments

@danielbankhead
Copy link
Member

danielbankhead commented Jan 7, 2022 •
edited

Now that gcs-resumable-upload has been merged into this library (#1736), we should consider a refactor:

  • Rename src/gcs-resumable-media/index.ts to src/gcs-resumable-upload.ts
  • Remove unnecessary dependencies in favor of native dependencies:
    • pumpify -> Stream
    • is-stream -> Stream
    • streamEvents (remove, unnecessary)
  • Tighten gcs-resumable-upload integration with File (shared type definitions, removing things that are optional that File wouldn't use, etc.)
@danielbankhead danielbankhead added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jan 7, 2022
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Jan 7, 2022
@danielbankhead danielbankhead changed the title Clean-up/Refactor for gcs-resumable-upload Clean-up for gcs-resumable-upload Jan 7, 2022
@shaffeeullah shaffeeullah mentioned this issue Feb 4, 2022
Merged
@danielduhh danielduhh added type: cleanup An internal cleanup or hygiene concern. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Feb 28, 2022
@danielduhh
Copy link

FYI @shaffeeullah @danielbankhead , I made this a checklist so we can track what we've done so far

@shaffeeullah shaffeeullah mentioned this issue Mar 14, 2022
Closed
@shaffeeullah shaffeeullah mentioned this issue Mar 30, 2022
Merged
@IchordeDionysos IchordeDionysos mentioned this issue Apr 21, 2022
Closed
@danielbankhead danielbankhead mentioned this issue Apr 25, 2022
Closed
@danielbankhead
Copy link
Member Author

AbortController isn't native in Node.js pre-v15... removing from the list for now

This was referenced May 5, 2022
Closed
Merged
@danielbankhead
Copy link
Member Author

Related:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielbankhead danielbankhead

Labels
api: storage Issues related to the googleapis/nodejs-storage API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(gcs-resumable-upload): Remove pumpify and stream-events googleapis/nodejs-storage
3 participants
@danielduhh @danielbankhead @shaffeeullah