feat(Core): add retryFunction in GrpcRequestWrapper::send #5770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
reviewed
Jan 9, 2023
bshaffer
approved these changes
Jan 11, 2023
Co-authored-by: Brent Shaffer <betterbrent@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core now allows adding
retryFunctionwithGrpcRequestWrapper::send. This will be used in Spanner'sBeginTransactionto retry forNot_FOUNDerrors with a custom pattern as followed in other languages.Code Pointer in TS
A similar change is also being taken by Go, googleapis/google-cloud-go#7163
Change
Adding a
retryFunctionwhich takes in an Exception as argument and produces a bool to decide whether to retry or not.Unit tests to validate cases such as whether
retryLimitis still honored and follows the custom logic provided.ref: b/263775077#comment8