Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Core): add retryFunction in Rest/Grpc traits #5782

Merged
merged 4 commits into from
Jan 17, 2023

Conversation

vishwarajanand
Copy link
Contributor

@vishwarajanand vishwarajanand commented Jan 12, 2023

Earlier we added support for retryFunction in GrpcRequestWrapper per #5770. With this change, we intend to surface those changes in GrpcTrait and RestTrait so that it can be consumed by respective implementations of ConnectionInterface directly.

Change

  1. Exposing retry function into rest/grpc traits
  2. Added tests for unit testing

Tests

google-cloud-php/Core % XDEBUG_MODE=debug vendor/bin/phpunit -c phpunit.xml.dist --filter="testSendsRequestWithRetryFunction"
PHPUnit 8.5.31 by Sebastian Bergmann and contributors.

..                                                                  2 / 2 (100%)

Time: 2.87 seconds, Memory: 14.00 MB

OK (2 tests, 4 assertions)
google-cloud-php/Core %

ref: b/263775077
Note: After these changes are picked up by a release PR, we can make final change in Spanner to use these changes.

@vishwarajanand vishwarajanand marked this pull request as ready for review January 12, 2023 11:11
@vishwarajanand vishwarajanand requested review from a team as code owners January 12, 2023 11:11
@dwsupplee dwsupplee merged commit e1fde13 into googleapis:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants