feat(internal/gapicgen): change versionClient for gapics #5687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we will add an init function that will set the versionClient var to the module version. This will improve version reporting for all calls.
|
Please see first commit to see what one of the generated files looks liked, reverted with second commit. |
codyoss
added a commit
to codyoss/gapic-generator-go
that referenced
this pull request
Feb 23, 2022
This will allow us to override the value after the client has been generated in an init function. For that code please see googleapis/google-cloud-go#5687
|
This requires googleapis/gapic-generator-go#912 to be merged and released. |
codyoss
added
the
do not merge
codyoss
added a commit
to googleapis/gapic-generator-go
that referenced
this pull request
Feb 23, 2022
This will allow us to override the value after the client has been generated in an init function. For that code please see googleapis/google-cloud-go#5687
codyoss
requested review from
a team,
dmahugh,
tritone and
telpirion
as code owners
product-auto-label
bot
added
size: m
codyoss
removed
the
do not merge
noahdietz
approved these changes
Feb 23, 2022
| @@ -254,39 +256,6 @@ go mod edit -dropreplace "google.golang.org/genproto" | |||
| return c.Run() | |||
| } | |||
|
|
|||
| // resetUnknownVersion resets doc.go files that have only had their version | |||
| // changed to UNKNOWN by the generator. | |||
| func (g *GapicGenerator) resetUnknownVersion() error { | |||
Merged
Merged
Merged
This was referenced Apr 14, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we will add an init function that will set the
versionClient var to the module version. This will improve version
reporting for all calls.