Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internal/gapicgen): fix logging yaml name #5674

Closed
wants to merge 1 commit into from

Conversation

noahdietz
Copy link
Contributor

The serivce config yaml for logging was renamed to conform, so we must rename it in the generation config.

@noahdietz noahdietz added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 18, 2022
@noahdietz noahdietz requested a review from a team as a code owner February 18, 2022 22:10
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Feb 18, 2022
@codyoss
Copy link
Member

codyoss commented Feb 23, 2022

Rolled this into #5687, closinig.

@codyoss codyoss closed this Feb 23, 2022
@codyoss codyoss deleted the logging-service-yaml branch May 17, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants