Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove misleading docs for credentialsFromJSON JWT path #2141

Merged
merged 5 commits into from Sep 12, 2023
Merged

chore: remove misleading docs for credentialsFromJSON JWT path #2141

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fe922ef
chore: remove misleading docs for credentialsFromJSON JWT path
rileykarson Sep 7, 2023
6d94557
Merge branch 'main' into patch-1
noahdietz Sep 11, 2023
ab8de70
Merge branch 'main' into patch-1
noahdietz Sep 11, 2023
cc61dbb
Merge branch 'main' into patch-1
noahdietz Sep 11, 2023
8eda11e
Merge branch 'main' into patch-1
codyoss Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions internal/creds.go
View file
Open in desktop
Expand Up @@ -78,9 +78,8 @@ const (
// met:
//
// (1) At least one of the following is true:
// (a) No scope is provided
// (b) Scope for self-signed JWT flow is enabled
// (c) Audiences are explicitly provided by users
// (a) Scope for self-signed JWT flow is enabled
// (b) Audiences are explicitly provided by users
// (2) No service account impersontation
//
// - Otherwise, executes standard OAuth 2.0 flow
Expand Down