Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove misleading docs for credentialsFromJSON JWT path #2141

Merged
merged 5 commits into from Sep 12, 2023

Conversation

rileykarson
Copy link
Contributor

This appears to have drifted in #1096, when the check for zero scopes in isSelfSignedJWTFlow was removed. Per the current rules, you either need to provide the internal option https://pkg.go.dev/google.golang.org/api/option/internaloption#EnableJwtWithScope or an explicit audience

@rileykarson rileykarson requested a review from a team as a code owner September 7, 2023 21:23
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Sep 7, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@rileykarson rileykarson changed the title Update credentialsFromJSON JWT docs to remove misleading path chore: remove misleading docs for Update credentialsFromJSON JWT Sep 7, 2023
@rileykarson rileykarson changed the title chore: remove misleading docs for Update credentialsFromJSON JWT chore: remove misleading docs for credentialsFromJSON JWT path Sep 7, 2023
Copy link
Contributor

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rileykarson

@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label Sep 11, 2023
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 11, 2023
@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label Sep 11, 2023
@noahdietz noahdietz enabled auto-merge (squash) September 11, 2023 23:25
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 12, 2023
@codyoss codyoss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2023
@codyoss codyoss added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Sep 12, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2023
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 12, 2023
@noahdietz noahdietz added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2023
@noahdietz noahdietz merged commit 2114d8d into googleapis:main Sep 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants