fix(storage): *int64 instead of int64 for Age cond #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
frankyn
added
the
status: blocked
codyoss
added
the
do not merge
tritone
added
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
tritone
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
tritone
approved these changes
Aug 16, 2022
codyoss
approved these changes
Aug 16, 2022
This was referenced Aug 17, 2022
tritone
added a commit
to googleapis/google-cloud-go
that referenced
this pull request
Aug 18, 2022
When googleapis/google-api-go-client#1598 is released; these tests will break due to the breaking change. This is a preemptive PR to skip these tests which will be reenabled once the break is released. Co-authored-by: Chris Cotter <cjcotter@google.com>
tritone
added a commit
to tritone/google-cloud-go
that referenced
this pull request
Aug 24, 2022
Bump dependency to pull in pointer field update for Lifecycle from googleapis/google-api-go-client#1598 Updates googleapis#6204
tritone
added a commit
to googleapis/google-cloud-go
that referenced
this pull request
Aug 24, 2022
Bump dependency to pull in pointer field update for Lifecycle from googleapis/google-api-go-client#1598 Updates #6204
|
this PR seems bad, it breaks pkg/mod/cloud.google.com/go/storage@v1.22.1/bucket.go:1504:30: cannot use r.Condition.AgeInDays (variable of type int64) as type *int64 in struct literal
pkg/mod/cloud.google.com/go/storage@v1.22.1/bucket.go:1592:30: cannot use rr.Condition.Age (variable of type *int64) as type int64 in struct literal |
|
Please upgrade your storage import to v1.26.0 and that error should go away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards unblocking: googleapis/google-cloud-go#6230
Change Storage OLM Age condition type from int64 to *int64 to allow for existence of check
Blocked by release and soak time of: googleapis/google-cloud-go#6230