Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(storage): skip tests using OLM Age condition #6538

Merged
merged 3 commits into from Aug 18, 2022

Conversation

frankyn
Copy link
Member

@frankyn frankyn commented Aug 17, 2022

When googleapis/google-api-go-client#1598 is released; these tests will break due to the breaking change. This is a preemptive PR to skip these tests which will be reenabled once the break is released.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the Cloud Storage API. labels Aug 17, 2022
@frankyn frankyn marked this pull request as ready for review August 17, 2022 23:46
@frankyn frankyn requested review from a team as code owners August 17, 2022 23:46
func TestBucketAttrsToRawBucket(t *testing.T) {
t.Skip()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a bug for the todo and put the link as an argument to the skip.

@frankyn frankyn requested a review from tritone August 18, 2022 16:26
@tritone tritone enabled auto-merge (squash) August 18, 2022 16:38
@tritone tritone merged commit e4f4509 into googleapis:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants