Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: re-enable OLM tests once generated library breaking change is released #6539

Closed
frankyn opened this issue Aug 18, 2022 · 0 comments · Fixed by #6204
Closed

storage: re-enable OLM tests once generated library breaking change is released #6539

frankyn opened this issue Aug 18, 2022 · 0 comments · Fixed by #6204
Assignees
@frankyn
Labels
api: storage Issues related to the Cloud Storage API. type: process A process-related concern. May include testing, release, or the like.

Comments

@frankyn
Copy link
Member

frankyn commented Aug 18, 2022

Storage generated client is releasing a breaking change to address Age: 0 being sent to and from GCS otherwise we can't determine existence of value googleapis/google-api-go-client#1598
@frankyn frankyn added the triage me I really want to be triaged. label Aug 18, 2022
@frankyn frankyn self-assigned this Aug 18, 2022
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Aug 18, 2022
@frankyn frankyn removed the triage me I really want to be triaged. label Aug 18, 2022
@frankyn frankyn added the type: process A process-related concern. May include testing, release, or the like. label Aug 18, 2022
@frankyn frankyn changed the title storage: re-enable tests once generated library breaking change is released storage: re-enable OLM tests once generated library breaking change is released Aug 18, 2022
@frankyn frankyn mentioned this issue Aug 24, 2022
Merged
tritone pushed a commit that referenced this issue Aug 26, 2022
@frankyn
fix(storage): allow to use age=0 in OLM conditions (#6204)
c85704f 
Storage Go doesn't allow setting AgeInDays=0 after discussing with @tritone. This PR is the agreed upon path to support Age=0 in OLM conditions. It also notes that other int fields in OLM Conditions do not support 0 values.

Fixes: #6539, #6240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frankyn frankyn

Labels
api: storage Issues related to the Cloud Storage API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(storage): allow to use age=0 in OLM conditions frankyn/google-cloud-go
2 participants
@frankyn @tritone