Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary CI fix for npm bug #290

Merged
merged 3 commits into from Jun 10, 2022
Merged

Temporary CI fix for npm bug #290

merged 3 commits into from Jun 10, 2022

Conversation

aomarks
Copy link
Member

@aomarks aomarks commented Jun 10, 2022

@aomarks aomarks requested a review from augustjk June 10, 2022 18:11
@augustjk
Copy link
Collaborator

Oh, oops, it's actually not just limited to 16. The default latest patch versions for 14 and 18 also are shipping with the problematic npm.

And the repo setting for required workflow seems like it needs updating.

Perhaps a better alternative might be to change the affected assertions to match rather than equal?

@augustjk
Copy link
Collaborator

Or doing the workaround mentioned here actions/runner-images#5716 (comment) as a windows-only workflow step might be worth trying?

@aomarks
Copy link
Member Author

aomarks commented Jun 10, 2022

Fixed it by just removing the culprit string from stderr as we report it from the test rig.

@aomarks aomarks enabled auto-merge (squash) June 10, 2022 21:19
@aomarks aomarks merged commit 04fd4d8 into main Jun 10, 2022
@aomarks aomarks deleted the pin-npm-16 branch June 10, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants