Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary CI fix for npm bug #223

Merged
merged 2 commits into from Jun 15, 2022

Conversation

AhmedElywa
Copy link
Contributor

@AhmedElywa AhmedElywa commented Jun 13, 2022

Our test has an error in the windows and node 16 test.

The issue comes from npm npm/cli#4980

I got the fix from here google/wireit#290 for now

@vercel
Copy link

vercel bot commented Jun 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nexus-prisma ✅ Ready (Inspect) Visit Preview Jun 13, 2022 at 7:58PM (UTC)

@AhmedElywa AhmedElywa changed the title fixed node 16 version to fix the tests npm issue Temporary CI fix for npm bug Jun 13, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #223 (b172045) into main (8b56ec9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage   55.46%   55.46%           
=======================================
  Files          45       45           
  Lines         640      640           
  Branches      115      115           
=======================================
  Hits          355      355           
  Misses        267      267           
  Partials       18       18           

@AhmedElywa
Copy link
Contributor Author

@andrewicarlson, @jasonkuhrt, it will be very helpful if anyone can merge this

@andrewicarlson andrewicarlson merged commit 772ffc7 into graphql-nexus:main Jun 15, 2022
@AhmedElywa AhmedElywa deleted the fix/test-node-version branch June 29, 2022 05:59
@rostislav-simonik-nexus-prisma-admin
Copy link
Collaborator

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants