Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infrastructure/#7458 - Create API endpoints and Redux store infrastructure for "Enable enhanced measurement" feature #7561

Merged
merged 60 commits into from
Sep 14, 2023
Merged

Infrastructure/#7458 - Create API endpoints and Redux store infrastructure for "Enable enhanced measurement" feature #7561

merged 60 commits into from
Sep 14, 2023

Commits on Aug 16, 2023

  1. Add support for enhanced measurement settings endpoints.

    @techanvil
    techanvil committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    f3266ca View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Add "Enable enhanced measurement" switch that takes its value from th… 

    …e currently selected data stream.
    @techanvil
    techanvil committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    9891a86 View commit details
    Browse the repository at this point in the history

  2. Refactor & enable the switch.

    @techanvil
    techanvil committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    f5c8796 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Add edit scope for POST endpoint.

    @techanvil
    techanvil committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    b084b7c View commit details
    Browse the repository at this point in the history

  2. Update EnhancedMeasurementToggle copy.

    @techanvil
    techanvil committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    581ebf7 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Fix typo.

    @techanvil
    techanvil committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    35369e3 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Merge branch 'develop' into infrastructure/#7458-enhanced-measurement.

    @hussain-t
    hussain-t committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    74fa59b View commit details
    Browse the repository at this point in the history

  2. Rename file

    @hussain-t
    hussain-t committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    3ab782f View commit details
    Browse the repository at this point in the history

  3. Add line break between methods

    @hussain-t
    hussain-t committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    96f7c69 View commit details
    Browse the repository at this point in the history

  4. Update renamed class instance

    @hussain-t
    hussain-t committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    90faac5 View commit details
    Browse the repository at this point in the history

  5. Update class name

    @hussain-t
    hussain-t committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    b1a3463 View commit details
    Browse the repository at this point in the history

  6. Rename PropertiesEnhancedMeasurementService class

    @hussain-t
    hussain-t committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    e22f9e0 View commit details
    Browse the repository at this point in the history

  7. Add enhancedMeasurementSettings fields validation.

    @hussain-t
    hussain-t committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    e09e97e View commit details
    Browse the repository at this point in the history

  8. Rename datastore file.

    @hussain-t
    hussain-t committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    55d5640 View commit details
    Browse the repository at this point in the history

  9. Rename enhancedMeasurements state to enhancedMeasurement.

    @hussain-t
    hussain-t committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    347b0b7 View commit details
    Browse the repository at this point in the history

  10. Add object shape validation.

    @hussain-t
    hussain-t committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    28ec938 View commit details
    Browse the repository at this point in the history

  11. Fix import after renaming.

    @hussain-t
    hussain-t committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    c53d26f View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Add actions.

    @hussain-t
    hussain-t committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    887c263 View commit details
    Browse the repository at this point in the history

  2. Add selectors.

    @hussain-t
    hussain-t committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    aa7fce0 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Add tests for EM selectors.

    @hussain-t
    hussain-t committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    20f6ff9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into infrastructure/#7458-enhanced-measurement.

    @hussain-t
    hussain-t committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    6b56e4b View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2023

  1. Add validations for the action params. 

    Fix set state logic.
    @hussain-t
    hussain-t committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    e02f74c View commit details
    Browse the repository at this point in the history

  2. Add tests for setEnhancedMeasurementSettings action.

    @hussain-t
    hussain-t committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    fb0797f View commit details
    Browse the repository at this point in the history

  3. Fix destructure params from validateParams.

    @hussain-t
    hussain-t committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    e418fab View commit details
    Browse the repository at this point in the history

  4. Fix post method path.

    @hussain-t
    hussain-t committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    5cd4a66 View commit details
    Browse the repository at this point in the history

  5. Add setEnhancedMeasurementsStreamEnabled tests.

    @hussain-t
    hussain-t committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    86a7b78 View commit details
    Browse the repository at this point in the history

  6. Add updateEnhancedMeasurementSettings tests.

    @hussain-t
    hussain-t committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    a2421e0 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Rename variable.

    @hussain-t
    hussain-t committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    1edc666 View commit details
    Browse the repository at this point in the history

  2. Add resetEnhancedMeasurementSettings tests. 

    Add period at the end of comments.
    @hussain-t
    hussain-t committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    d29db92 View commit details
    Browse the repository at this point in the history

  3. Add enhanced-measurement-settings endpoint in test_get_datapoints.

    @hussain-t
    hussain-t committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    febcf12 View commit details
    Browse the repository at this point in the history

  4. FDix lint error

    @hussain-t
    hussain-t committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    d221d1b View commit details
    Browse the repository at this point in the history

  5. Fix PHP lint errors

    @hussain-t
    hussain-t committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    a9f3de8 View commit details
    Browse the repository at this point in the history

  6. Revert to developt changes in the setup form.

    @hussain-t
    hussain-t committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    cc9cc5d View commit details
    Browse the repository at this point in the history

  7. Remove EnhancedMeasurementToggle file.

    @hussain-t
    hussain-t committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    491b7e9 View commit details
    Browse the repository at this point in the history

  8. Add JSDoc comment for setEnhancedMeasurementStreamEnabled.

    @hussain-t
    hussain-t committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    579fa56 View commit details
    Browse the repository at this point in the history

  9. Add break instead of return statements.

    @hussain-t
    hussain-t committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    22ace94 View commit details
    Browse the repository at this point in the history

  10. Avoid mutating the state in the selector.

    @hussain-t
    hussain-t committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    ece6fab View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Merge branch 'develop' into infrastructure/#7458-enhanced-measurement.

    @hussain-t
    hussain-t committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    9e75cab View commit details
    Browse the repository at this point in the history

  2. Add get enhanced-measurement-settings PHP tests.

    @hussain-t
    hussain-t committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    70d5302 View commit details
    Browse the repository at this point in the history

  3. Add fields.

    @hussain-t
    hussain-t committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    a9d6dc1 View commit details
    Browse the repository at this point in the history

  4. Add validation fields.

    @hussain-t
    hussain-t committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    4d09b4c View commit details
    Browse the repository at this point in the history

  5. Add enhanced_mesurement_settings post tests.

    @hussain-t
    hussain-t committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    8363449 View commit details
    Browse the repository at this point in the history

  6. Fix PHP lint errors

    @hussain-t
    hussain-t committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    a36e970 View commit details
    Browse the repository at this point in the history

  7. Add EnhancedMeasurementSettingsModel class.

    @hussain-t
    hussain-t committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5d719f4 View commit details
    Browse the repository at this point in the history

  8. Use EnhancedMeasurementSettingsModel class.

    @hussain-t
    hussain-t committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    7e37aaf View commit details
    Browse the repository at this point in the history

  9. Remove old API properties

    @hussain-t
    hussain-t committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    162bdaf View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. php ignore file the api client class

    @hussain-t
    hussain-t committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    13b9cf5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into infrastructure/#7458-enhanced-measurement.

    @hussain-t
    hussain-t committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    623d00b View commit details
    Browse the repository at this point in the history

  3. Fix php lint errors.

    @hussain-t
    hussain-t committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    29688ce View commit details
    Browse the repository at this point in the history

  4. Use EnhancedMeasurementSettingsModel class.

    @hussain-t
    hussain-t committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    0d519e8 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into infrastructure/#7458-enhanced-measurement.

    @hussain-t
    hussain-t committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    64d9574 View commit details
    Browse the repository at this point in the history

  6. Shallow clone the state. 

    Revert the immutable logic.
    @hussain-t
    hussain-t committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    0884d53 View commit details
    Browse the repository at this point in the history

  7. Extract logic to a utility function.

    @hussain-t
    hussain-t committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    6c3d7fb View commit details
    Browse the repository at this point in the history

  8. Update error message assertions in the tests.

    @hussain-t
    hussain-t committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    8b9b60a View commit details
    Browse the repository at this point in the history

  9. Move enhancedMeasurementSettingsMock to beforeEach.

    @hussain-t
    hussain-t committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    7e65d52 View commit details
    Browse the repository at this point in the history

  10. Pass the mock copy instead of the original object.

    @hussain-t
    hussain-t committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    1de7e90 View commit details
    Browse the repository at this point in the history

  11. Fix var name.

    @hussain-t
    hussain-t committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    67c6958 View commit details
    Browse the repository at this point in the history

  12. Fix typo and grammatical errors.

    @hussain-t
    hussain-t committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    c79affd View commit details
    Browse the repository at this point in the history

  13. Add create_enhanced_measurement_fake_http_handler method.

    @hussain-t
    hussain-t committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    9708121 View commit details
    Browse the repository at this point in the history

  14. Update PHP tests to mock em data field.

    @hussain-t
    hussain-t committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    11b20fe View commit details
    Browse the repository at this point in the history