Infrastructure/#7458 - Create API endpoints and Redux store infrastructure for "Enable enhanced measurement" feature

[hussain-t]

Summary

Addresses issue:

• Create API endpoints and Redux store infrastructure for "Enable enhanced measurement" feature. #7458

Relevant technical choices

• While working on this feature, the getAnalyticsConfigByMeasurementIDs selector's tests failed. The selector was directly mutating the Redux state, which conflicts with our usage of createReducer from Immer.
• I have fixed it with a non-mutating approach. Please refer to this commit.
• This PR contains a new EnhancedMeasurementSettingsModel class, a copy of the GoogleAnalyticsAdminV1alphaEnhancedMeasurementSettings class from the Google API client library. Please refer to this comment.

PR Author Checklist

• My code is tested and passes existing unit tests.
• My code has an appropriate set of unit tests which all pass.
• My code is backward-compatible with WordPress 5.2 and PHP 5.6.
• My code follows the WordPress coding standards.
• My code has proper inline documentation.
• I have added a QA Brief on the issue linked above.
• I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

• Run the code.
• Ensure the acceptance criteria are satisfied.
• Reassess the implementation with the IB.
• Ensure no unrelated changes are included.
• Ensure CI checks pass.
• Check Storybook where applicable.
• Ensure there is a QA Brief.

Merge Reviewer Checklist

• Ensure the PR has the correct target branch.
• Double-check that the PR is okay to be merged.
• Ensure the corresponding issue has a ZenHub release assigned.
• Add a changelog message to the issue.

[techanvil]

Hey @hussain-t, nice work here. I've left a number of comments, the majority of which are very minor. Please take a look :)

[techanvil]

LGTM, nice work @hussain-t!

[aaemnnosttv]

@techanvil I noticed this during review after it was already merged and perhaps it's inconsequential, but this is an example where the naming is inconsistent as was flagged in the original IBR (plural/singular).

Secondarily, the resource (datastream) is a sub-resource of the property but this not reflected. We should already have the class for properties->datastreams, so perhaps we can extend the class in the library instead? This way once the library is updated to a version which includes it, we wouldn't need to change its usage. See https://gist.github.com/aaemnnosttv/ede786f6caa7679cac981669c2f90cb5#file-googleanalyticsadmin-php-L1209

[techanvil]

@techanvil I noticed this during review after it was already merged and perhaps it's inconsequential, but this is an example where the naming is inconsistent as was flagged in the original IBR (plural/singular).

Hi @aaemnnosttv, thanks for spotting this - this one slipped through the net in CR. AFAICT it's the only instance where we use the inconsistent plural naming. Tbh it's pretty marginal but I'm happy to create a followup issue to address if you think it's worthwhile doing so, please let me know (or we could just include it in some other future PR)...

Secondarily, the resource (datastream) is a sub-resource of the property but this not reflected. We should already have the class for properties->datastreams, so perhaps we can extend the class in the library instead? This way once the library is updated to a version which includes it, we wouldn't need to change its usage. See https://gist.github.com/aaemnnosttv/ede786f6caa7679cac981669c2f90cb5#file-googleanalyticsadmin-php-L1209

Hmm, I'm a bit unclear what version your gist represents... In our current version, v0.277.0, the PropertiesDataStreams class is used for the v2alpha API, and I'd be hesitant to reuse it for the v1alpha EM API methods that we're reintroducing here. I did consider extending PropertiesWebDataStreams, but that would mean we're bringing some additional methods in that support the v1alpha data stream API & associated classes that we don't need.

I thought it would be cleaner to simply copy the stuff we do need from the old version of PropertiesWebDataStreams instead into a new class. With these being v1alpha methods, I'm not sure how likely it would be for it to be reintroduced in a compatible manner in PropertiesDataStreams anyway, and I would imagine it's more likely we'll need to rework our implementation a bit when the beta API does provide support for EM.

That's my thinking here anyway, but I'm certainly open to suggestion if you want to take a different course with this.