*layout.layoutIndex implements Layer(Hash) for compatibility with remote.WriteIndex #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ote.WriteIndex remote.Pusher detects an ImageIndex's children using partial.ComputeManifests, which gets and uploads a v1.Layer element _if the index implements withLayer_. This change satisfies that condition.
bmoylan
commented
Jan 19, 2024
| @@ -126,6 +126,19 @@ func (i *layoutIndex) Blob(h v1.Hash) (io.ReadCloser, error) { | |||
| return i.path.Blob(h) | |||
| } | |||
|
|
|||
| // Workaround for #819. | |||
There was a problem hiding this comment.
I noticed this comment in other locations where the private interfaces exposing extra extensibility are implemented
|
This Pull Request is stale because it has been open for 90 days with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remote.Pusher detects an ImageIndex's children using partial.ComputeManifests, which gets and uploads a v1.Layer element if the index implements withLayer.
This change satisfies that condition, allowing for uploading an index containing non-image entries in a layout.
Thanks in advance!