Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate.Layer: handle validation for layer content that is not compressed #1866

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nmiyake
Copy link

@nmiyake nmiyake commented Jan 19, 2024

Fixes #1826

@nmiyake
Copy link
Author

nmiyake commented Jan 19, 2024

@bmoylan for reference

@nmiyake nmiyake force-pushed the validateLayerWithNonCompressedContent branch from ec6ece2 to 5532eb0 Compare January 20, 2024 00:27
Copy link

@bmoylan bmoylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @nmiyake this should fix the test failures I have in #1865

@@ -21,6 +21,8 @@ import (
"encoding/hex"
"errors"
"fmt"
"github.com/google/go-containerregistry/internal/compression"
comp "github.com/google/go-containerregistry/pkg/compression"

This comment was marked as resolved.

Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crane: validate fails with invalid header message on image with uncompressed layers mediaType
2 participants