Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docstore/all: Fix offset handling and extend test coverage #3409

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

docstore/all: Fix offset handling and extend test coverage #3409

wants to merge 4 commits into from

Commits on Mar 22, 2024

  1. docstore/awsdynamodb: Fix Query for cases where the underlying query … 

    …to AWS returns an empty set, but there's still more data
    @vangent
    vangent committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    82e5f0a View commit details
    Browse the repository at this point in the history

  2. fix(docstore/memdocstore): Refine offset handling in RunGetQuery 

    This commit adjusts `RunGetQuery` to return an empty slice when the offset is greater than or equal to the result set length, previously this was not handled correctly.
    @bartventer
    bartventer committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    b7f352d View commit details
    Browse the repository at this point in the history

  3. test(docstore/awsdynamodb): Increase test coverage for documentIterat… 

    …or.Next

This commit enhances the test coverage for `documentIterator.Next` in `docstore/awsdynamodb/query_test.go`.

Related: google#3408
    @bartventer
    bartventer committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    e275d75 View commit details
    Browse the repository at this point in the history

  4. test(docstore/all): Extend test coverage for Limit/Offset related que… 

    …ries

- This commit extends the test coverage for Offset and Limit related queries in `docstore/drivertest/drivertest.go`.
- Added additional test cases for `Limit` and `Offset` to `TestInvalidQuery` in `docstore/query_test.go`.

Related: google#3408
    @bartventer
    bartventer committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    9d139c9 View commit details
    Browse the repository at this point in the history