docstore/all: Fix offset handling and extend test coverage #3409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to AWS returns an empty set, but there's still more data
This commit adjusts `RunGetQuery` to return an empty slice when the offset is greater than or equal to the result set length, previously this was not handled correctly.
…or.Next This commit enhances the test coverage for `documentIterator.Next` in `docstore/awsdynamodb/query_test.go`. Related: google#3408
…ries - This commit extends the test coverage for Offset and Limit related queries in `docstore/drivertest/drivertest.go`. - Added additional test cases for `Limit` and `Offset` to `TestInvalidQuery` in `docstore/query_test.go`. Related: google#3408
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3409 +/- ##
==========================================
+ Coverage 73.12% 73.26% +0.13%
==========================================
Files 113 113
Lines 14864 14869 +5
==========================================
+ Hits 10870 10894 +24
+ Misses 3219 3207 -12
+ Partials 775 768 -7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of PR #3408 and includes additional changes:
RunGetQueryindocstore/memdocstore.documentIterator.Nextindocstore/awsdynamodb. I'm not sure how realistic these test cases are, I can remove them if they don't add value.docstore.I also generated new replay files for
awsdynamodbandgcpfirestore.