docstore/awsdynamodb: Fix Query for cases where the underlying query to AWS returns an empty set, but there's still more data #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3408 +/- ##
==========================================
+ Coverage 73.15% 73.16% +0.01%
==========================================
Files 113 113
Lines 14872 14874 +2
==========================================
+ Hits 10880 10883 +3
Misses 3218 3218
+ Partials 774 773 -1 ☔ View full report in Codecov by Sentry. |
vangent
force-pushed
the
awsdynamo
branch
3 times, most recently
from
d18befa
to
82e5f0a
Compare
bartventer
added a commit
to bartventer/go-cloud
that referenced
this pull request
Mar 22, 2024
…or.Next This commit enhances the test coverage for `documentIterator.Next` in `docstore/awsdynamodb/query_test.go`. Related: google#3408
bartventer
added a commit
to bartventer/go-cloud
that referenced
this pull request
Mar 22, 2024
…ries - This commit extends the test coverage for Offset and Limit related queries in `docstore/drivertest/drivertest.go`. - Added additional test cases for `Limit` and `Offset` to `TestInvalidQuery` in `docstore/query_test.go`. Related: google#3408
…to AWS returns an empty set, but there's still more data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3405