Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoids pre-validating the nearest enclosing type in the InjectProcessingStep. #3524

Closed
wants to merge 1 commit into from
Closed

Avoids pre-validating the nearest enclosing type in the InjectProcessingStep. #3524

wants to merge 1 commit into from

Commits on Aug 11, 2022

  1. Avoids pre-validating the nearest enclosing type in the InjectProcess… 

    …ingStep.

Fixes #3522

The pre-validation should no longer be needed as `InjectValidator` validates everything itself. In addition, the pre-validation is overly broad, and validates types that are not necessary for Dagger to validate the class.

RELNOTES=Fixes #3522: Avoids pre-validating the nearest enclosing type in the InjectProcessingStep.
PiperOrigin-RevId: 466812816
    @bcorso
    bcorso authored and Dagger Team committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    ccecfee View commit details
    Browse the repository at this point in the history