Avoids pre-validating the nearest enclosing type in the InjectProcessingStep. #3524
+155
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…ingStep. Fixes #3522 The pre-validation should no longer be needed as `InjectValidator` validates everything itself. In addition, the pre-validation is overly broad, and validates types that are not necessary for Dagger to validate the class. RELNOTES=Fixes #3522: Avoids pre-validating the nearest enclosing type in the InjectProcessingStep. PiperOrigin-RevId: 466812816
copybara-service
bot
force-pushed
the
test_466812816
branch
from
aa180c3
to
ccecfee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids pre-validating the nearest enclosing type in the InjectProcessingStep.
Fixes #3522
The pre-validation should no longer be needed as
InjectValidatorvalidates everything itself. In addition, the pre-validation is overly broad, and validates types that are not necessary for Dagger to validate the class.RELNOTES=Fixes #3522: Avoids pre-validating the nearest enclosing type in the InjectProcessingStep.