New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump github.com/go-critic/go-critic from 0.4.1 to 0.4.3 #1148
build(deps): bump github.com/go-critic/go-critic from 0.4.1 to 0.4.3 #1148
Conversation
we need to manually fix newly found issues |
Do we just fix the issues in this PR and push on this branch or should I create a new branch and merge to master before re-running these tests? Also, isn't all those errors false positives? It seems like defer statements in the end of a block (even if it's an if-statement) is seen as last before return. Example for line 138 in golangci-lint/test/testshared/testshared.go Lines 137 to 148 in 09df97a
Maybe remove the check from the CI linting before the false positive is fixed? |
thank you for the related issue in |
Bumps [github.com/go-critic/go-critic](https://github.com/go-critic/go-critic) from 0.4.1 to 0.4.3. - [Release notes](https://github.com/go-critic/go-critic/releases) - [Commits](go-critic/go-critic@v0.4.1...v0.4.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
b3f11f6
to
001ce5f
Compare
I did what I thought was right and resolved the bug upstream instead. 😄 I'll ignore this check until a new go-critic version is released. |
Uhh, it seems like the task fails because I'm disabling the check that was failing by saying it's disabled by default. It still proceeds but fails since it doesn't recognize the linter being disabled.
I'll see what I can find! EDIT: As far as I can tell the This is the result of me running this locally (but the steps manually). # make golangci-lint
$ go build -o golangci-lint ./cmd/golangci-lint && echo "Ok"
Ok
# make test (first step without `-v` flag)
$ GL_TEST_RUN=1 ./golangci-lint run && echo "Ok"
Ok Had some issues with EDIT2: I should read the code before I write... I see that the step failing is in the action where we run What's the preferred way forward here? Do we ever want to be able to run those steps with different configurations? This time it's a bug but I guess similar things would be of interest for actual changes too? |
Probably we can exclude this check by |
@ernado Yeah I thought that was what I did in my last commit (8a749af) but the build still fails. This is how I tried to exclude the check. I think the reason is because the action runs an older version of |
@bombsimon I was talking about |
@ernado Oh, of course, that's would solve the issue! I'll push a new change! |
let's update it to |
Does It looks like not, because it was introduced in gocritic update (which is in current PR) |
ok, got it |
Bumps github.com/go-critic/go-critic from 0.4.1 to 0.4.3.
Release notes
Sourced from github.com/go-critic/go-critic's releases.
Commits
8c5f841
checkers: add ruleguard checker (#907)0d5eff4
checkers: add draw.Draw to draw.DrawMask checker (#904)5714434
checkers: rename deferAtTheEnd to unnecessaryDefer (#902)3062653
checker: add defer at the end of function checker (#901)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.
You can always request more updates by clicking
Bump now
in your Dependabot dashboard.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in the
.dependabot/config.yml
file in this repo: