checker: add defer at the end of function checker #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janisz
force-pushed
the
defer_at_the_end
branch
from
792624d
to
9f83419
Compare
cristaloleg
previously approved these changes
Jan 20, 2020
checkers/deferAtTheEnd_checker.go
Outdated
| if fnlit.Body.List == nil { | ||
| s += "{}" | ||
| } else { | ||
| s += "{…}" |
There was a problem hiding this comment.
TBH I would like to omit Unicode characters as stick to simple ASCII.
| fnlit, ok := deferStmt.Call.Fun.(*ast.FuncLit) | ||
| if ok { | ||
| // To avoid long and multi-line warning messages, | ||
| // collapse the function literals. |
| } | ||
| }() | ||
| return | ||
| } |
There was a problem hiding this comment.
Looks good, I'm curious, will it handle defer inside if? :)
Even if no - it can be marked as a TODO comment.
janisz
force-pushed
the
defer_at_the_end
branch
from
9f83419
to
f099cf7
Compare
Detects uneeded defer at the end of function.
janisz
force-pushed
the
defer_at_the_end
branch
from
f099cf7
to
486d4e1
Compare
quasilyte
approved these changes
Jan 20, 2020
cristaloleg
approved these changes
Jan 20, 2020
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detects uneeded defer at the end of function.