False positive for unnecessaryDefer

[bombsimon]

It seems like the check for unnecessaryDefer only checks if the defer statement is the last statement in a block, no matter what block it is. Because of this it's not possible to set conditional defer statements.

Noticed this when a build in golangci-lint failed. Here's a smaller example to reproduce.

package main

import "fmt"

func main() {
    if true {
        defer func() {
            fmt.Println("something was true")
        }()
    }

    fmt.Println("more code before return")
}

$ gocritic check -enable='unnecessaryDefer' ./...
./main.go:7:3: unnecessaryDefer: defer func(){...}(...) is placed just before return

[quasilyte]

Fixed in #927