Support Caching in Mono Repo #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbernays
force-pushed
the
master
branch
2 times, most recently
from
53f5bc5
to
58bce52
Compare
|
@ldez - Is there anything about this PR that is blocking it being merged? |
|
@ldez any plans to tag a new release? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the
go.modis used as the cache key is expected to always be at the root of the repository. This works for most repositories but when users have a mono repo and supply aworking-directorythe caching keys should use that as the root directory insteadThis PR fixes #479
Also wanted to add that we use golangci extensively in in CloudQuery and this would definitely help us avoid hitting timeouts...