New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve linting perf via caching #5900
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I have opened a PR with this functionality in the |
.github/workflows/source_aws.yml
Outdated
@@ -54,7 +54,7 @@ jobs: | |||
cache: true | |||
cache-dependency-path: plugins/source/aws/go.sum | |||
- name: golangci-lint | |||
uses: golangci/golangci-lint-action@v3 | |||
uses: bbernays/golangci-lint-action@58bce521b66ed125524e24eeec9522d765a8c2a7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put the fork under cloudquery/
and also use the branch name directly cloudquery/golangci-lint-action@master
so if we follow up with fixes we don't have to update this sha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bbernays, added a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, we can follow up with our own forked version later on if they don't accept the fix
Summary