Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 HTTP/2 Feature #1796

Closed
wants to merge 18 commits into from
Closed

🚀 HTTP/2 Feature #1796

wants to merge 18 commits into from

Conversation

balcieren
Copy link
Contributor

@balcieren balcieren commented Feb 28, 2022

Usage :

	app := fiber.New(fiber.Config{
		EnableHTTP2: true, // Default: false
	})

	app.Get("/http11", func(c *fiber.Ctx) error {
		return c.JSON(c.IsHTTP11()) //return true without http2 client support
	})

	app.Get("/http2", func(c *fiber.Ctx) error {
		return c.JSON(c.IsHTTP2()) //return true via http2 client support
	})

	app.ListenTLS(":8080", ".github/testdata/public.crt", ".github/testdata/private.key")

Issue #1683

To Do List

  • Add property to app's config.
  • Compatible with prefork.
  • ListenTLS with HTTP/2.
  • ListenMutualTLS with HTTP/2.
  • Add IsHTTP2 and IsHTTP11 functions to context.
  • HTTP2 client support.
  • Add tests.

ZAAAA

@balcieren balcieren mentioned this pull request Feb 28, 2022
5 tasks
@efectn efectn marked this pull request as draft February 28, 2022 19:42
@gaby
Copy link
Member

gaby commented Apr 21, 2022

@balcieren @efectn Any updates on this?

@efectn
Copy link
Member

efectn commented Apr 21, 2022

@balcieren @efectn Any updates on this?

Waiting for:

@balcieren
Copy link
Contributor Author

@balcieren @efectn Any updates on this?

We are waiting to stable version.

@HiperMaximus
Copy link

Bump

Bumps [github.com/valyala/fasthttp](https://github.com/valyala/fasthttp) from 1.35.0 to 1.38.0.
- [Release notes](https://github.com/valyala/fasthttp/releases)
- [Commits](valyala/fasthttp@v1.35.0...v1.38.0)

---
updated-dependencies:
- dependency-name: github.com/valyala/fasthttp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…/valyala/fasthttp-1.38.0

Bump github.com/valyala/fasthttp from 1.35.0 to 1.38.0
@mikestopcontinues
Copy link

Bump

@gaby
Copy link
Member

gaby commented Aug 15, 2022

@mikestopcontinues Sadly, this is blocked by the 2 open PR's mentioned before.

@HasanMdArik
Copy link

@mikestopcontinues Sadly, this is blocked by the 2 open PR's mentioned before.

do you mean those issues right?

@efectn
Copy link
Member

efectn commented Sep 26, 2022

Closed the PR due to inactivity of dgrr/http2

@efectn efectn closed this Sep 26, 2022
@mikestopcontinues
Copy link

@efectn Is there a plan for what to do instead?

@efectn
Copy link
Member

efectn commented Sep 26, 2022

@efectn Is there a plan for what to do instead?

No, we don't have any plan at the moment

@kitsuniru
Copy link

@balcieren @efectn Any updates on this?

Waiting for:

Seems like they are forked http2 and fixed those issues

https://github.com/diamondcdn/fasthttp-http2

@gaby
Copy link
Member

gaby commented Nov 26, 2022

@efectn Maybe this can be re-evaluated with the fork?

@efectn
Copy link
Member

efectn commented Nov 27, 2022

Sure

trajan0x added a commit to synapsecns/sanguine that referenced this pull request Dec 17, 2022
fixes issue described in gofiber/fiber#1796
trajan0x added a commit to synapsecns/sanguine that referenced this pull request Dec 17, 2022
* fix omnirpc issue

fixes issue described in gofiber/fiber#1796

* fix generate errors

Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>
aureliusbtc pushed a commit to aureliusbtc/sanguine-contracts-core that referenced this pull request Aug 11, 2023
* fix omnirpc issue

fixes issue described in gofiber/fiber#1796

* fix generate errors

Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants