Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix omnirpc issue #426

Merged
merged 2 commits into from
Dec 17, 2022
Merged

fix omnirpc issue #426

merged 2 commits into from
Dec 17, 2022

Conversation

trajan0x
Copy link
Contributor

fixes issue described in gofiber/fiber#1796

Description

Right now http2 is broken resulting in frequent panics (see: dgrr/http2#59 and dgrr/http2#58). Diamondcdn has fixed these issues here: https://github.com/diamondcdn/fasthttp-http2

image

Additional context
Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

fixes issue described in gofiber/fiber#1796
@github-actions github-actions bot added 2-reviewers go Pull requests that update Go code M-contracts Module: Contracts labels Dec 17, 2022
@github-actions github-actions bot temporarily deployed to Preview December 17, 2022 03:07 Inactive
@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Base: 34.41220% // Head: 34.41220% // No change to project coverage 👍

Coverage data is based on head (a511e6f) compared to base (87b1cf1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##              master        #426   +/-   ##
=============================================
  Coverage   34.41220%   34.41220%           
=============================================
  Files            432         432           
  Lines          43935       43935           
  Branches         160         160           
=============================================
  Hits           15119       15119           
- Misses         26947       26948    +1     
+ Partials        1869        1868    -1     
Impacted Files Coverage Δ
services/omnirpc/http/fasthttp.go 73.33333% <ø> (ø)
ethergo/chain/watcher/height.go 70.00000% <0.00000%> (-30.00000%) ⬇️
ethergo/chain/chainwatcher/height.go 53.65854% <0.00000%> (-10.97562%) ⬇️
ethergo/chain/block.go 68.54839% <0.00000%> (-1.61290%) ⬇️
ethergo/backends/base/base.go 59.60265% <0.00000%> (+2.64900%) ⬆️
services/scribe/client/clients.go 59.37500% <0.00000%> (+3.12500%) ⬆️
agents/domains/evm/evm.go 67.64706% <0.00000%> (+8.82352%) ⬆️
agents/indexer/domain.go 65.45455% <0.00000%> (+10.90909%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot temporarily deployed to Preview December 17, 2022 03:10 Inactive
@github-actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: a511e6f
✅ Preview: https://sanguine-o2xz12myc-synapsecns.vercel.app
🔍 Inspect: https://vercel.com/synapsecns/sanguine/EPEjCAyNvy44i75yjRayKGqeJTGL

View Workflow Logs

@trajan0x trajan0x marked this pull request as ready for review December 17, 2022 03:18
@trajan0x trajan0x merged commit 160b6ee into master Dec 17, 2022
@trajan0x trajan0x deleted the fix/omnirpc branch December 17, 2022 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-reviewers deployed go Pull requests that update Go code M-contracts Module: Contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant