Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for cops introduced by 0.85 #68

Merged
merged 6 commits into from Jul 8, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
@@ -1,6 +1,14 @@
Changelog
=========

2.15.0
------
* Support new cop introduced by rubocop v0.87: `Style/AccessorGrouping` (disabled by default),
`Style/BisectedAttrAccessor` and `Style/RedundantAssignment`
* Support new cop introduced by rubocop v0.86: `Style/RedundantFetchBlock`
* Support new cops introduced by rubocop v0.85: `Lint/MixedRegexpCaptureTypes`, `Style/RedundantRegexpEscape`
and `Style/RedundantRegexpCharacterClass`

2.14.0
------
* Enable a new cop introduced by rubocop v0.84: `Lint/DeprecatedOpenSSLConstant`
Expand Down
4 changes: 2 additions & 2 deletions gc_ruboconfig.gemspec
Expand Up @@ -2,15 +2,15 @@

Gem::Specification.new do |spec|
spec.name = 'gc_ruboconfig'
spec.version = '2.14.0'
spec.version = '2.15.0'
spec.summary = "GoCardless's shared Rubocop configuration, conforming to our house style"
spec.authors = %w[GoCardless]
spec.homepage = 'https://github.com/gocardless/ruboconfig'
spec.email = %w[developers@gocardless.com]
spec.license = 'MIT'

spec.files = 'rubocop.yml'
spec.add_dependency 'rubocop', '>= 0.84'
spec.add_dependency 'rubocop', '>= 0.87'
spec.add_dependency 'rubocop-rspec', '>= 1.38.1'
spec.add_dependency 'rubocop-performance', '~> 1.5'
end
21 changes: 21 additions & 0 deletions rubocop.yml
Expand Up @@ -24,6 +24,9 @@ Lint/RaiseException:
Lint/StructNewOverride:
Enabled: true

Lint/MixedRegexpCaptureTypes:
Enabled: true

Metrics/ClassLength:
Enabled: false

Expand Down Expand Up @@ -171,5 +174,23 @@ Style/ExponentialNotation:
Style/SlicingWithRange:
Enabled: true

Style/RedundantRegexpCharacterClass:
Enabled: true

Style/RedundantRegexpEscape:
ivgiuliani marked this conversation as resolved.
Show resolved Hide resolved
Enabled: true

Style/RedundantFetchBlock:
Enabled: true

Style/AccessorGrouping:
Enabled: false

Style/BisectedAttrAccessor:
Enabled: true

Style/RedundantAssignment:
Enabled: true

Lint/DeprecatedOpenSSLConstant:
Enabled: true