Enable support for cops introduced by 0.85 #68
Conversation
Namely: - `Lint/MixedRegexpCaptureTypes` - `Style/RedundantRegexpCharacterClass` (disabled by default due to rubocop/rubocop#8098) - `Style/RedundantRegexpEscape`
|
Would be also good to include the new cops from https://github.com/gocardless/payments-service/pull/25348 |
The outstanding issue in Rubocop has now been fixed.
CHANGELOG.md
Outdated
| @@ -1,6 +1,14 @@ | |||
| Changelog | |||
| ========= | |||
|
|
|||
| 2.15.0 | |||
| ------ | |||
| * Support new cop introduced by rubocop v0.87: `Style/AccessorGrouping`, `Style/BisectedAttrAccessor` | |||
There was a problem hiding this comment.
How do we feel about Style/AccessorGrouping? It groups blocks of attr_reader/writer together (see https://docs.rubocop.org/rubocop/cops_style.html#styleaccessorgrouping), but in cases where we've got a lot of them it may be better to split them logically
There was a problem hiding this comment.
I think that's an element of personal style that I'd rather avoid forcing, e.g. this should be fine:
class Foo
attr_reader :public_attr
private
attr_reader :private_attr
end
There was a problem hiding this comment.
I don't feel strongly here myself; if this would cause lots of churn for us then it's probably not worth it. If it only affects a few places then might be worth turning it on.
There was a problem hiding this comment.
Alright I think I'll disable it for now, tried it in PS and I'm not convinced the proposed changes would make it any better
Namely:
Lint/MixedRegexpCaptureTypesStyle/RedundantRegexpCharacterClassStyle/RedundantRegexpEscapeStyle/AccessorGroupingStyle/BisectedAttrAccessorStyle/RedundantAssignmentStyle/RedundantFetchBlock