Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Japanese translation of max-items, lt-items and lte-items error #1250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −6
Open

Fix Japanese translation of max-items, lt-items and lte-items error #1250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions translations/ja/ja.go
View file
Open in desktop
Expand Up @@ -230,7 +230,7 @@ func RegisterDefaultTranslations(v *validator.Validate, trans ut.Translator) (er
return
}

if err = ut.Add("max-items", "{0}は最大でも{1}を含まなければなりません", false); err != nil {
if err = ut.Add("max-items", "{0}は最大でも{1}でなければなりません", false); err != nil {
return
}
// if err = ut.AddCardinal("max-items-item", "{0}つの項目", locales.PluralRuleOne, false); err != nil {
Expand Down Expand Up @@ -405,7 +405,7 @@ func RegisterDefaultTranslations(v *validator.Validate, trans ut.Translator) (er
return
}

if err = ut.Add("lt-items", "{0}は{1}よりも少ない項目を含まなければなりません", false); err != nil {
if err = ut.Add("lt-items", "{0}は{1}よりも少ない項目でなければなりません", false); err != nil {
return
}

Expand Down Expand Up @@ -525,7 +525,7 @@ func RegisterDefaultTranslations(v *validator.Validate, trans ut.Translator) (er
return
}

if err = ut.Add("lte-items", "{0}は最大でも{1}を含まなければなりません", false); err != nil {
if err = ut.Add("lte-items", "{0}は最大でも{1}でなければなりません", false); err != nil {
return
}

Expand Down
6 changes: 3 additions & 3 deletions translations/ja/ja_test.go
View file
Open in desktop
Expand Up @@ -518,7 +518,7 @@ func TestTranslations(t *testing.T) {
},
{
ns: "Test.LteMultiple",
expected: "LteMultipleは最大でも2つの項目を含まなければなりません",
expected: "LteMultipleは最大でも2つの項目でなければなりません",
},
{
ns: "Test.LteTime",
Expand All @@ -534,7 +534,7 @@ func TestTranslations(t *testing.T) {
},
{
ns: "Test.LtMultiple",
expected: "LtMultipleは2つの項目よりも少ない項目を含まなければなりません",
expected: "LtMultipleは2つの項目よりも少ない項目でなければなりません",
},
{
ns: "Test.LtTime",
Expand Down Expand Up @@ -574,7 +574,7 @@ func TestTranslations(t *testing.T) {
},
{
ns: "Test.MaxMultiple",
expected: "MaxMultipleは最大でも7つの項目を含まなければなりません",
expected: "MaxMultipleは最大でも7つの項目でなければなりません",
},
{
ns: "Test.MinString",
Expand Down