Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Japanese translation of max-items, lt-items and lte-items error #1250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tomoki108
Copy link

Fixes

In English version, max-items error message is "{0} must contain at maximum {1}". (ref)
And current Japanese translation "{0}は最大でも{1}を含まなければなりません" is strait translation of English version but quite unnatural for Japanese.

We don’t usually use a sentence like "含まなければなりません" ("must contain") in this context. Because it can not "contain" any items further. So, we simply say "{0}は最大でも{1}でなければなりません" ("{0} must be at maximum {1}") instead.

"lt-items" and "lte-items" messages have same issue as above. (if those errors occur, it can not contain any items further as well.)


Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@Tomoki108 Tomoki108 requested a review from a team as a code owner April 14, 2024 10:06
@coveralls
Copy link

Coverage Status

coverage: 74.208%. remained the same
when pulling dd22b67 on Tomoki108:fix-ja-translator
into a0f74b0 on go-playground:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants