plumbing: transport/ssh, support more formats in NewPublicKeys SSH helper
#298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you rabase? |
Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
ssh-transport-key-formats
branch
from
66723ca
to
04d17c1
Compare
By switching to `ParsePrivateKey` and `ParsePrivateKeyWithPassphrase` from `crypto/ssh`, which has support for RSA (PKCS#1), PKCS#8, DSA (OpenSSL), and ECDSA private keys. Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
ssh-transport-key-formats
branch
from
04d17c1
to
022cc6c
Compare
|
Done. |
mcuadros
changed the title
NewPublicKeys SSH helperNewPublicKeys SSH helper
hiddeco
added a commit
to fluxcd/flux2
that referenced
this pull request
May 10, 2021
This changes the logic for the parsing of private keys, as already done for the source-controller, so that it is able to recognize and work with a wider range of key formats instead of returning a vague error: ```console $ flux bootstrap git [..] ✗ ssh: this private key is passphrase protected ``` A patch for this was already submitted and merged in `go-git/go-git`, but is not made available in a release yet: go-git/go-git#298 Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
added a commit
to fluxcd/flux2
that referenced
this pull request
May 10, 2021
This changes the logic for the parsing of private keys, as already done for the source-controller, so that it is able to recognize and work with a wider range of key formats instead of returning a vague error: ```console $ flux bootstrap git [..] ✗ ssh: this private key is passphrase protected ``` A patch for this was already submitted and merged in `go-git/go-git`, but is not made available in a release yet: go-git/go-git#298 Signed-off-by: Hidde Beydals <hello@hidde.co>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #297