Fetch submodules pointing to orphaned but still reachable commits #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcuadros, gentle ping. I'll appreciate if you could take a look. This fix will help FreeBSD folks test FreeBSD on Cirrus CI faster. |
|
any chance to do a test? |
Sure, if you don't mind accepting a PR with a single commit first and then dropping the tree it belongs to. I assume I'll need to create a PR in https://github.com/git-fixtures/basic? |
|
Yup, there is a submodule fixture but maybe is not enough. |
Well, OK 🤷 It seems that the |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes submodules are not updated for long periods of time and the tree that holds the commit they point to gets removed at some point, which results in commits that are orphaned, but still reachable using
allow-reachable-sha1-in-wantGit's wire protocol capability.Here's a real case: cirruslabs/cirrus-ci-docs#830 (comment).
This change makes sure go-git will behave similarly to Git in such cases, which does a subsequent fetch using a commit hash.