Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document CIRRUS_CLONE_SUBMODULES #830

Merged
merged 3 commits into from Mar 31, 2021
Merged

Document CIRRUS_CLONE_SUBMODULES #830

merged 3 commits into from Mar 31, 2021

Conversation

edigaryev
Copy link
Contributor

@emaste
Copy link
Contributor

emaste commented Mar 30, 2021

I tried to use this on my submodules project: emaste/freebsd@8c152bf

But it looks like the submodules were not populated: https://cirrus-ci.com/task/6005207805984768

I'll try to look into what happened. Maybe interaction with CIRRUS_CLONE_DEPTH?

@edigaryev
Copy link
Contributor Author

I tried to use this on my submodules project: emaste/freebsd@8c152bf

But it looks like the submodules were not populated: https://cirrus-ci.com/task/6005207805984768

I'll try to look into what happened. Maybe interaction with CIRRUS_CLONE_DEPTH?

You did everything right! This just hasn't been rolled out yet.

It probably will be after this PR gets merged 🙌

@edigaryev edigaryev marked this pull request as draft March 30, 2021 21:27
@edigaryev edigaryev marked this pull request as ready for review March 31, 2021 19:53
@fkorotkov fkorotkov merged commit 98352a2 into master Mar 31, 2021
@fkorotkov
Copy link
Contributor

It should be available now.

@fkorotkov fkorotkov deleted the cirrus-clone-submodules branch March 31, 2021 19:54
@emaste
Copy link
Contributor

emaste commented Apr 2, 2021

Looks like it is not working for me - compare https://cirrus-ci.com/build/5139496078409728 and https://cirrus-ci.com/task/4625231508668416

The first sets CIRRUS_CLONE_SUBMODULES: true and the second runs git submodule init and git submodule update. The first reports

Updating submodules...
Failed to update submodules: object not found!

@edigaryev
Copy link
Contributor Author

Looks like it is not working for me - compare https://cirrus-ci.com/build/5139496078409728 and https://cirrus-ci.com/task/4625231508668416

The first sets CIRRUS_CLONE_SUBMODULES: true and the second runs git submodule init and git submodule update. The first reports

Updating submodules...
Failed to update submodules: object not found!

It seems that the emaste/drm-kmod@b57b441 commit referenced from the drm-kmod submodule is orphaned and that causes the object not found error.

What's interesting though is how git submodule update manages to fetch it anyway, while go-git fails.

I'll take a look at this, but for a quick workaround you can assign this commit to some branch or tag as recommended in GitHub documentation.

@edigaryev
Copy link
Contributor Author

Turns out that the official Git implementation does a second fetch attempt, while go-git doesn't, more details in go-git/go-git#284.

Let's see how long it takes for the upstream to merge the fix, while you can still use the workaround above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants