Ensure codemod mode ignores whitespace control. #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`handlebars.parse` automatically applies whitespace control to the AST before it is returned. For example, parsing the following template ([feel free to review the AST on ASTExplorer](https://astexplorer.net/#/gist/f850c5457b808756107c0bc5ad226989/b0366df64be5c01b5f9eadd93e795b3b9d65d2c7)): ```hbs {{#foo}} {{~bar~}} {{baz~}} {{/foo}} ``` Using `Handlebars.parse`, the AST returned would have truncated the following whitespace: * The whitespace prior to the `{{#foo}}` * The newline following `{{#foo}}` * The leading whitespace before `{{~bar~}}` * The whitespace between `{{~bar~}}` and `{{baz~}}` * The newline after `{{baz~}}` * The whitespace prior to the `{{/foo}}` A future version of `handlebars` (likely 4.5.0) will have a new method named `parseWithoutProcessing`. When we update to that version we can remove the custom workaround here.
|
Labeling this as "breaking" since the impact to tooling currently using |
rwjblue
commented
Oct 28, 2019
| let parseOptions = options.parseOptions || {}; | ||
|
|
||
| if (mode === 'codemod') { | ||
| parseOptions.ignoreStandalone = true; |
There was a problem hiding this comment.
FYI - ignoreStandalone is not used in parseWithoutProcessing mode so no need to preserve passing it here.
rwjblue
added a commit
to rwjblue/ember-template-recast
that referenced
this pull request
Oct 28, 2019
This updates to `@glimmer/syntax@0.43.0` which includes glimmerjs/glimmer-vm#983.
This was referenced Oct 28, 2019
This was referenced Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handlebars.parseautomatically applies whitespace control to the AST before it is returned. For example, parsing the following template (feel free to review the AST on ASTExplorer):Using
Handlebars.parse, the AST returned would have truncated the following whitespace:{{#foo}}{{#foo}}{{~bar~}}{{~bar~}}and{{baz~}}{{baz~}}{{/foo}}The inline
parseWithoutProcessingmethod can be removed when we update to a version ofhandlebarsthat includes handlebars-lang/handlebars.js#1584 (likely to be 4.5.0).