Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to handlebars@4.5.1. #986

Merged
merged 1 commit into from Oct 29, 2019
Merged

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Oct 29, 2019

handlebars@4.5.0+ has a new method handlebars.parseWithoutProcessing, which we were emulating.

This PR updates the minimum Handlebars version to ensure that we have the new API available (from handlebars-lang/handlebars.js#1584), and removes the work around added in #983.

handlebars@4.5.0+ has a new method `handlebars.parseWithoutProcessing`,
which we were emulating. This removes the workaround and uses the new
public API.
@rwjblue
Copy link
Member Author

rwjblue commented Oct 29, 2019

#983 introduce the same change (and was deemed "breaking" to existing mode: 'codemod' users), since this is just removing our internal work around in favor of public APIs it is not breaking (and not terribly important 😛 ).

@rwjblue rwjblue merged commit 0fd6681 into glimmerjs:master Oct 29, 2019
@rwjblue rwjblue deleted the update-handlebars branch October 29, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant