Fix warning from upstream rubocop #57
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,8 @@ | ||
| inherit_from: ./config/default.yml | ||
|
|
||
| require: | ||
| - rubocop-performance | ||
|
|
||
| Naming/FileName: | ||
| Enabled: true | ||
| Exclude: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ git: | |
| depth: 10 | ||
|
|
||
| rvm: | ||
| - 2.4.6 | ||
| - 2.5.5 | ||
| - 2.6.3 | ||
| - 2.7.1 | ||
|
There was a problem hiding this comment. For future debugging purposes, can we put CI changes in a separate PR? There was a problem hiding this comment. sure, let me bring it in separate PR then There was a problem hiding this comment. It looks like we'll need to do this PR first, then the CI PR since CI is breaking on the warnings :) There was a problem hiding this comment. yes, but I got CI test failure on 2.3 for this PR :( There was a problem hiding this comment. It looks like on 2.3 it failed with https://travis-ci.org/github/github/rubocop-github/jobs/676500683 Which is odd, since you fixed that. I didn't chase it further (maybe there's another place where it's being used?) |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,3 +2,5 @@ | |
|
|
||
| source "https://rubygems.org" | ||
| gemspec | ||
|
|
||
| gem "rubocop-performance", require: false | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are some of the renamed checks in Rubocop Performance, or is this a separate change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, we are using some Performance cops in the
.rubocop.ymlof rubocop-github itself, and I got errors whenrubocop-performanceis not required