Fix warning from upstream rubocop #57
Conversation
The .rubocop.yml for rubocop-github itself is: `inherit_from: ./config/default.yml`, which `inherit_from: default_deprecated.yml`, which `inherit_from: _default_shared.yml`, which is using some Performance cop there.
| @@ -1,5 +1,8 @@ | |||
| inherit_from: ./config/default.yml | |||
|
|
|||
| require: | |||
| - rubocop-performance | |||
There was a problem hiding this comment.
Are some of the renamed checks in Rubocop Performance, or is this a separate change?
There was a problem hiding this comment.
hmm, we are using some Performance cops in the .rubocop.yml of rubocop-github itself, and I got errors when rubocop-performance is not required
| - 2.4.6 | ||
| - 2.5.5 | ||
| - 2.6.3 | ||
| - 2.7.1 |
There was a problem hiding this comment.
For future debugging purposes, can we put CI changes in a separate PR?
There was a problem hiding this comment.
sure, let me bring it in separate PR then
There was a problem hiding this comment.
It looks like we'll need to do this PR first, then the CI PR since CI is breaking on the warnings :)
There was a problem hiding this comment.
yes, but I got CI test failure on 2.3 for this PR :(
There was a problem hiding this comment.
It looks like on 2.3 it failed with Layout/IndentationStyle:
https://travis-ci.org/github/github/rubocop-github/jobs/676500683
Which is odd, since you fixed that. I didn't chase it further (maybe there's another place where it's being used?)
Style/EndBlock&Lint/EndInMethodare redundant rubocop/rubocop#7813LineLengthcop fromMetricstoLayoutdepartment rubocop/rubocop#7542