Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace Changes for RuboCop 0.70 #38

Merged
merged 14 commits into from Jun 5, 2019
Merged

Namespace Changes for RuboCop 0.70 #38

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
807655d
Namespace Changes
joshRpowell Apr 5, 2019
45d8040
Rename to Strip
joshRpowell Apr 5, 2019
df96784
Sort alphabetically
joshRpowell Apr 11, 2019
89c9a35
Set rubocop @ 0.67 to capture changes
joshRpowell Apr 11, 2019
b1d4a48
Set ruby version to min tested in travis.yml
joshRpowell Apr 11, 2019
7fd9b22
Merge branch 'master' into patch-1
joshRpowell Apr 23, 2019
fd67704
Remove duplicate Style/Strip
joshRpowell May 10, 2019
1711996
bump to rubocop 0.68
joshRpowell May 10, 2019
106b7b9
Bump rubocop to 0.69
joshRpowell May 13, 2019
a37135f
Bump rubocop to 0.70
joshRpowell May 22, 2019
497386d
Adds rubocop-performance dependency
joshRpowell May 30, 2019
08682a1
Require rubocop-performance
joshRpowell May 30, 2019
9eb5012
Fix require
joshRpowell May 30, 2019
cfd1da9
Merge branch 'master' into patch-1
MrChrisW Jun 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 14 additions & 12 deletions config/default.yml
View file
Open in desktop
@@ -1,4 +1,6 @@
require: rubocop/cop/github
require:
- rubocop/cop/github
- rubocop-performance

AllCops:
DisabledByDefault: true
Expand Down Expand Up @@ -115,6 +117,9 @@ Lint/EndInMethod:
Lint/EnsureReturn:
Enabled: true

Lint/FlipFlop:
Enabled: true

Lint/FloatOutOfRange:
Enabled: true

Expand Down Expand Up @@ -236,15 +241,9 @@ Performance/RedundantMerge:
Enabled: true
MaxKeyValuePairs: 1

Performance/RedundantSortBy:
Enabled: true

Performance/ReverseEach:
Enabled: true

Performance/Sample:
Enabled: true

Performance/Size:
Enabled: true

Expand Down Expand Up @@ -281,9 +280,6 @@ Style/DefWithParentheses:
Style/EndBlock:
Enabled: true

Style/FlipFlop:
Enabled: true

Style/For:
Enabled: true

Expand Down Expand Up @@ -315,12 +311,18 @@ Style/Not:
Style/OneLineConditional:
Enabled: true

Style/StabbyLambdaParentheses:
Style/RedundantSortBy:
Enabled: true

Style/Strip:
Style/Sample:
Enabled: true

Style/StabbyLambdaParentheses:
Enabled: true

Style/StringLiterals:
Enabled: true
EnforcedStyle: double_quotes

Style/Strip:
Enabled: true
5 changes: 3 additions & 2 deletions rubocop-github.gemspec
View file
Open in desktop
Expand Up @@ -10,13 +10,14 @@ Gem::Specification.new do |s|

s.files = Dir["README.md", "STYLEGUIDE.md", "LICENSE", "config/*.yml", "lib/**/*.rb", "guides/*.md"]

s.add_dependency "rubocop", "~> 0.59"
s.add_dependency "rubocop", "~> 0.70"
s.add_dependency "rubocop-performance", "~> 1.3.0"

s.add_development_dependency "actionview", "~> 5.0"
s.add_development_dependency "minitest", "~> 5.10"
s.add_development_dependency "rake", "~> 12.0"

s.required_ruby_version = ">= 2.1.0"
s.required_ruby_version = ">= 2.3.6"

s.email = "engineering@github.com"
s.authors = "GitHub"
Expand Down