Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace Changes for RuboCop 0.70 #38

Merged
merged 14 commits into from Jun 5, 2019
Merged

Namespace Changes for RuboCop 0.70 #38

merged 14 commits into from Jun 5, 2019

Conversation

joshRpowell
Copy link
Contributor

@joshRpowell joshRpowell commented Apr 5, 2019 •
edited

Drops support for Ruby < 2.3

@joaoffcosta
Copy link

@joshRpowell I believe this is no longer a WIP as the title suggests. I'm using your branch and it seems to be working great 👍

@joshRpowell joshRpowell changed the title [WIP] Namespace Changes Namespace Changes May 13, 2019
@joshRpowell joshRpowell changed the title Namespace Changes Namespace Changes for RuboCop 0.69 May 13, 2019
@joshRpowell joshRpowell changed the title Namespace Changes for RuboCop 0.69 Namespace Changes for RuboCop 0.70 May 22, 2019
@MrChrisW
Copy link
Member

Thanks for this @joshRpowell 👍 I think we may want to add https://github.com/rubocop-hq/rubocop-performance as a dependency since rubocop/rubocop#5977 ?

Warning: unrecognized cop Performance/CaseWhenSplat found in config/default.yml
Warning: unrecognized cop Performance/Count found in config/default.yml
Warning: unrecognized cop Performance/Detect found in config/default.yml
Warning: unrecognized cop Performance/DoubleStartEndWith found in config/default.yml
Warning: unrecognized cop Performance/EndWith found in config/default.yml
Warning: unrecognized cop Performance/FlatMap found in config/default.yml
Warning: unrecognized cop Performance/RangeInclude found in config/default.yml
Warning: unrecognized cop Performance/RedundantMatch found in config/default.yml
Warning: unrecognized cop Performance/RedundantMerge found in config/default.yml
Warning: unrecognized cop Performance/ReverseEach found in config/default.yml
Warning: unrecognized cop Performance/Size found in config/default.yml

@MrChrisW MrChrisW self-requested a review May 30, 2019 00:49
@joshRpowell
Copy link
Contributor Author

@MrChrisW great catch! had added in app, but didn't circle back. removed in app after adding the dependency here and all is green.

MrChrisW
MrChrisW approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@MrChrisW MrChrisW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MrChrisW
Copy link
Member

@joshRpowell no problem! thanks again for tackling this 🎊

fyi @jhawthorn as you seem active here 😊 looks like we'll need to cut a new release once this is merged

@MrChrisW MrChrisW merged commit b29714a into github:master Jun 5, 2019
@tma tma mentioned this pull request Jun 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrChrisW MrChrisW MrChrisW approved these changes

Assignees

@joshRpowell joshRpowell

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joshRpowell @joaoffcosta @MrChrisW