Skip to content

Commit

Permalink
Simplify SliceValidationError Error method
Browse files Browse the repository at this point in the history
  • Loading branch information
huangzw committed Mar 29, 2024
1 parent 7a865dc commit 317d118
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 20 deletions.
23 changes: 7 additions & 16 deletions binding/default_validator.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,25 +22,16 @@ type SliceValidationError []error

// Error concatenates all error elements in SliceValidationError into a single string separated by \n.
func (err SliceValidationError) Error() string {
n := len(err)
switch n {
case 0:
return ""
default:
var b strings.Builder
if err[0] != nil {
fmt.Fprintf(&b, "[%d]: %s", 0, err[0].Error())
}
if n > 1 {
for i := 1; i < n; i++ {
if err[i] != nil {
b.WriteString("\n")
fmt.Fprintf(&b, "[%d]: %s", i, err[i].Error())
}
var b strings.Builder
for i := range err {
if err[i] != nil {
if b.Len() > 0 {
b.WriteString("\n")
}
fmt.Fprintf(&b, "[%d]: %s", i, err[i].Error())
}
return b.String()
}
return b.String()
}

var _ StructValidator = (*defaultValidator)(nil)
Expand Down
12 changes: 8 additions & 4 deletions binding/default_validator_benchmark_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,15 @@ import (

func BenchmarkSliceValidationError(b *testing.B) {
const size int = 100
e := make(SliceValidationError, size)
for j := 0; j < size; j++ {
e[j] = errors.New(strconv.Itoa(j))
}

b.ReportAllocs()
b.ResetTimer()

for i := 0; i < b.N; i++ {
e := make(SliceValidationError, size)
for j := 0; j < size; j++ {
e[j] = errors.New(strconv.Itoa(j))
}
if len(e.Error()) == 0 {
b.Errorf("error")
}
Expand Down

0 comments on commit 317d118

Please sign in to comment.