read/archive: locate members by table in AIX archive #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipc
requested changes
Sep 22, 2022
philipc
reviewed
Sep 22, 2022
ecnelises
force-pushed
the
aix_members
branch
from
6a22218
to
c58b6aa
Compare
philipc
approved these changes
Sep 30, 2022
philipc
reviewed
Sep 30, 2022
| let table_size = parse_u64_digits(&header.size, 10) | ||
| .read_error("Invalid AIX big archive member size")?; | ||
| let members_count = data | ||
| .read_bytes_at(member_table_offset, 30) |
There was a problem hiding this comment.
Should this have been a length of 20?
I'll do a followup PR for some other things, so I'll change this if needed.
There was a problem hiding this comment.
Ah, it should be 20, Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is from review of #462. Iterating over members by member table can avoid potential infinite loop if the file is malformed. Also, this change sets
namesfor a parsed file.