read/archive: AIX big archive enhancements #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Include magic in `AixFileHeader`. - Move AIX file header parsing into separate function. - Use `ArchiveMember::parse_aixbig` to parse the members for the symbol tables and member index. - Add `Members` enum for `ArchiveFile::members` instead of overloading the meaning of fields. - Fix length of member index count (20 instead of 30). - Add `AixMemberOffset` to simplify member index parsing. - Read the entire member index array at once. This avoids some overflow checking. - Don't set `ArchiveFile::names` since it isn't used.
ecnelises
approved these changes
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AixFileHeader.ArchiveMember::parse_aixbigto parse the members for the symbol tables and member index.Membersenum forArchiveFile::membersinstead of overloading the meaning of fields.AixMemberOffsetto simplify member index parsing.ArchiveFile::namessince it isn't used.Followup to #467. @ecnelises Can you test and review please?